On Thu, Dec 17, 2009 at 10:28:21PM +0200, Felipe Balbi wrote: > On Thu, Dec 17, 2009 at 08:40:32PM +0100, ext Candelaria Villareal, Jorge wrote: > >+config SND_OMAP_SOC_MCPDM > >+ tristate > look at how SND_OMAP_SOC_N810 is done, can't you follow that ? put some > description ad help ? This is fine - DAI drivers should be selected by machine drivers rather than by users since they are useless without the machine drivers. This means that they shouldn't have a description. > >+EXPORT_SYMBOL(omap_mcpdm_start); > >+EXPORT_SYMBOL(omap_mcpdm_stop); > >+EXPORT_SYMBOL(omap_mcpdm_set_uplink); > >+EXPORT_SYMBOL(omap_mcpdm_set_downlink); > >+EXPORT_SYMBOL(omap_mcpdm_clr_uplink); > >+EXPORT_SYMBOL(omap_mcpdm_clr_downlink); > >+EXPORT_SYMBOL(omap_mcpdm_request); > >+EXPORT_SYMBOL(omap_mcpdm_free); > way too many exported symbols, no ? Doesn't ALSA API have proper place > for this kind of stuff ? I'd need ALSA experts to reply to that but it > does smell funny... With the McBSP these things are all exported because the McBSP isn't just used by ALSA, I beleive, but a PDM interface is probably only ever going to be used by audio. _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
