Dear Mark > > +#define DA7210_BUS 0 > > +#define DA7210_ADR (0x34 >> 1) > > +static int da7210_add_i2c_device(void) > > +{ > > This should be being done by the arch code rather than here, and there's > no code to remove the device on shutdown. This idiom has been used by > some drivers as part of a transition from the old style ASoC stuff where > the I2C device was registered in the CODEC to reduce cross tree issues > but it's best to avoid it for new code. Wow... I should modify ak4642 / fsi-ak4642 too Best regards -- Kuninori Morimoto _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel