At Fri, 27 Nov 2009 18:18:33 +0100, Ondrej Zary wrote: > > On Friday 27 November 2009 07:59:26 Jaroslav Kysela wrote: > > On Thu, 26 Nov 2009, Ondrej Zary wrote: > > > When primary AC97 is not found, don't fail with tons of AC97 errors. > > > Assume that the card is SF64-PCR (tuner-only). > > > This makes the SF64-PCR radio card work "out of the box". > > > > I would leave the possibility to force FM tuner only detection without > > touching AC97 bus. The auto detection is a good idea. Could you recode > > your patch? > > Here it is. > BTW. Looks like the tuner could be detected automatically provided that > someone has the different cards to test. > > > > When primary AC97 is not found, don't fail with tons of AC97 errors. > Assume that the card is SF64-PCR (tuner-only). > This makes the SF64-PCR radio card work "out of the box". > > Also fixes a bug that can cause an oops here: > if (tea575x_tuner > 0 && (tea575x_tuner & 0x000f) < 4) { > when tea575x_tuner == 16, it passes this check and causes problems > a couple lines below: > chip->tea.ops = &snd_fm801_tea_ops[(tea575x_tuner & 0x000f) - 1]; > > > Tested with SF64-PCR, but I don't have any of those sound or sound+radio cards > to test if I didn't break anything. > > > Signed-off-by: Ondrej Zary <linux@xxxxxxxxxxxxxxxxxxxx> Looks good to me. Now applied. Thanks. Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel