On Mon, Nov 23, 2009 at 12:00:01PM +0000, Mark Brown wrote: > On Sat, Nov 21, 2009 at 08:12:34PM -0600, Timur Tabi wrote: > > > Why did you write a new SSI driver when there already is one in sound/soc/fsl? > > I can't speak for Sascha here but the i.MX BSPs provided by your > colleagues on the i.MX team also have an independant driver for the SSI > port. The latest public version of the Freescale i.MX code I'm aware of > is in the recent Ubuntu kernels - I've not yet checked but I'd not be > surprised to see substantial code sharing between Sascha's code and the > BSP for the SSI-specific bits. > > It would be very much desirable to unify the various drivers, though I > would prefer to avoid making this a blocker for getting i.MX3x "DMA" > support in mainline. Taking a brief glance through the code it looks > like there's some platform-specifics in the drivers - the i.MX one has > optional DMA support due to the whole SDMA issue, while the PowerPC one > is including asm/immap_86xx.h for something. This include seems unused. Timur, can you confirm this? Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
