On Wed, 18 Nov 2009 03:40:40 -0700 (MST) Paul Walmsley <paul@xxxxxxxxx> wrote: > In the interim, I would suggest that you remove the the clock source and > receiver source change functions from omap-mcbsp.c, split them into OMAP1 > and OMAP2/3 variants, and place them into arch/arm/mach-omap*/mcbsp.c. > Expand struct omap_mcbsp_ops to add function pointers to those functions. > Call those from soc/omap-mcbsp.c via mcbsp->pdata->ops. That way you won't > need those exports. > Paul: What's your opinnion, would it be possible or would it be wise to handle these McBSP clock route setups with the clock framework instead? Functions omap_mcbsp_dai_set_clks_src and omap_mcbsp_dai_set_rcvr_src are basically just setting up the input clock for McBSP SRG or McBSP1 receiver. > I don't understand how this code compiled on OMAP1 in any case, since it > doesn't have a System Control Module. > OMAP1 can include control.h as well :-) Access is anyway protected with the cpu_class_is_omap1(). -- Jarkko _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
