On Wed, Nov 18, 2009 at 05:04:20PM +0800, Takashi Iwai wrote: > At Wed, 18 Nov 2009 12:38:03 +0800, > Wu Fengguang wrote: > > > > This avoids lost of presence info on module reloading. > > The presence info used to be only updated at the (rare) hotplug events. > > > > Proposed by David, thanks! > > > > CC: David Härdeman <david@xxxxxxxxxxx> > > Signed-off-by: Wu Fengguang <fengguang.wu@xxxxxxxxx> > > I think we should handle this also at resume. > Typically, the codec resume callback calls the unsolicited event > explicitly. > > But, the resume callback can be used for resuming from the > power-saving mode, too. Thus it should be optimized and less > verbose, e.g. cache the ELD bytes, compare the new data with the > cached data, and skip the procedure if it's the same content. > > Anyway, all patches have been applied, so let's fix this on the > current tree. OK, thanks for the tips. Actually I have not tested suspend/resume yet, I will do it next week. Currently I have some pending items (that's why I have to put off the keep-power-on patch). Thanks, Fengguang _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel