At Thu, 12 Nov 2009 10:54:02 +0100 (CET), noreply-git@xxxxxxxxxxxxxxxx wrote: > > commit 6739046df36c7adf80c961bcba4870270e66dbf6 > Author: Jaroslav Kysela <perex@xxxxxxxx> > AuthorDate: Thu Nov 12 10:15:48 2009 +0100 > Commit: Jaroslav Kysela <perex@xxxxxxxx> > CommitDate: Thu Nov 12 10:51:48 2009 +0100 > > ALSA: hda - proc - add support for dynamic controls to mixer<->NID mapping > > This patch adds support for dynamically created controls to proc codec file > (Control: lines). > > Signed-off-by: Jaroslav Kysela <perex@xxxxxxxx> > > commit c45b73bf328cd8ace53cf39994328cf9d6548c4f > Author: Jaroslav Kysela <perex@xxxxxxxx> > AuthorDate: Wed Nov 11 13:43:01 2009 +0100 > Commit: Jaroslav Kysela <perex@xxxxxxxx> > CommitDate: Thu Nov 12 10:51:16 2009 +0100 > > ALSA: hda - proc - introduce Control: lines to show mixer<->NID assignment > > This is an initial patch to show universal control<->NID assigment in > proc codec file. The change helps to debug codec related problems. > > Signed-off-by: Jaroslav Kysela <perex@xxxxxxxx> I find the second one is the nice hack, but the first (newer) one isn't good since it abuses the subdevice field of the ctl id. It is a part of API/ABI, and if we do any changes the semantics, we should define the changed behavior *beforehand* publicly. Also, both commits give many warnings via checkpatch.pl... So I postpone the merge so far. thanks, Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
