On Sat, Nov 7, 2009 at 12:09 AM, Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote: > On Fri, Nov 06, 2009 at 11:48:30PM +0900, jassi brar wrote: >> On Fri, Nov 6, 2009 at 10:13 PM, Mark Brown > >> > I'll apply this but I beleive the driver ought to be smarter with the >> > clocks - AFAICT from the documentation the audio bus clock is not >> > guaranteed to be needed. > >> this patch only adds the missing code, its no modification. > > I'm not sure what you mean by that? Sorry, if its hard to understand what i write. I will write detailed explanation. Seems the clk_enable for cclk went 'missing' during segregation of one driver into separate SoC specific(s3c2412, s3c64xx) and version specific(s3c-i2s-v2) parts.. PCLK(iis) and CLKAUDIO(audio-bus) are equally potential candidates of I2S source clock. If the driver gets and enables 'iis' there is no reason why it should only get and not enable 'audio-bus'. By the design of the driver, clk_enable for 'audio-bus' too ought to be in driver (just like 'iis'). If some user is enabling it somewhere else, he/she is not in line with the design. > Presumably any system that's > managing to use the driver as-is is doing so by clocking the block from > something other than the audio clock so from their point of view it > isn't needed. Why overlook the right but missing part? just because users have a work around? >> s3c64xx-i2s driver sure needs to be upgraded, which i plan to do soon if >> nobody else does. > > Any news on IISv4 port support? It'd be good to get the SMDKs to the > point where they can actually play audio. I had been expecting some > followups from your previous patches. I will resend some patches which were given reviews. I just got busy. Due to different official priorities, the 6channel support implementation got delayed. It is definitely on my todo list. _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
