Re: [PATCH] Add support for CLKOUT to wm8731 codec driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Mark Brown wrote:
>
>> +		dev_dbg(codec->dev, PREFIX "%s turning off CLKOUT\n", __func__);
>> +		reg = wm8731_read_reg_cache(codec, WM8731_PWR);
>> +		reg |= (1 << WM8731_PWR_CLKOUTPD);
>> +		wm8731_write(codec, WM8731_PWR, reg);
>> +	}
>>     
>
> It'd be better define a new clock for the CLKOUT pin rather than munging
> it in with the master clock.  MCLK is always an input on the WM8731, the
> CLKOUT output is a separate pin and so including it in MCLK is likely to
> make things confusing and could well introduce errors.
>   

Could you explain more about what you meant by this?  I'm trying to
rework these patches now, and I don't understand how to implement what
you are suggesting.


b.g.

-- 
Bill Gatliff
bgat@xxxxxxxxxxxxxxx

_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux