On Wed, 21 Oct 2009 20:35:40 +0200
Janusz Krzysztofik <jkrzyszt@xxxxxxxxxxxx> wrote:
>
> + if (cpu_class_is_omap1())
> + return 0;
> +
> omap_set_dma_src_burst_mode(prtd->dma_ch, OMAP_DMA_DATA_BURST_16);
> omap_set_dma_dest_burst_mode(prtd->dma_ch, OMAP_DMA_DATA_BURST_16);
>
I would have implemented this by "if (!cpu_class_is_omap1())
{..._burst_mode}" for making sure that no new OMAP1 error is introduced
in the future if there is need to add some common stuff after those
burst_mode calls and probably compiler can better optimize away those
burst_mode calls for OMAP1 builds.
--
Jarkko
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
