On Monday 19 October 2009 15:55:08 ext Mark Brown wrote:
> On Mon, Oct 19, 2009 at 03:42:19PM +0300, Peter Ujfalusi wrote:
> > + apll_ctrl = twl4030_read_reg_cache(codec, TWL4030_REG_APLL_CTL);
> > + apll_ctrl &= ~TWL4030_APLL_INFREQ;
> > switch (freq) {
>
> I'll apply this - it's idiomatic for the current driver - but you might
> want to look at snd_soc_update_bits() which does a read/modify/write
> cycle for you.
>
Yeah, it is a good idea.
I'll address this when I go through the soc codec driver in my planned revisit
and cleanup round quite soon.
Thanks,
Péter
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
