On Wednesday 14 October 2009 07:50:39 Nurkkala Eero.An (EXT-Offcode/Oulu) wrote: > On Tue, 2009-10-13 at 14:03 +0200, Ujfalusi Peter (Nokia-D/Tampere) > wrote: > > Having two almost identical functions probably "rang the bells" with you > also. > > How about: > > static int dac33_write_locked(struct snd_soc_codec *codec, unsigned int > reg, unsigned int value) > { > int ret; > > mutex_lock(); > ret = dac33_write(codec, reg, value); > mutex_unlock(); > > return ret; > } > > (one way around it) Yes, good idea. I'll send another patch, but I want to wait for Mark's comments first, and address his concerns as well, if he has. -- Péter _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel