PATCH: ESI Juli@ fails to set sample rate

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This one-line patch fixes bug https://bugs.launchpad.net/ubuntu/+source/linux/+bug/441446
and is likely to fix bug https://bugzilla.redhat.com/show_bug.cgi?id=525595
as well.

The problem for me is that if two streams are started immediately after one another (such as a playback and a recording stream, e g pulseaudio does that on startup), the call to hw_params fail with EBUSY. This patch makes the call succeed, and playback and recording works.

I do not have any other ice1724 soundcard than the ESI Juli@ so I don't know if/how this patch will affect them.

// David
diff --git a/sound/pci/ice1712/ice1724.c b/sound/pci/ice1712/ice1724.c
index cc84a83..56d1bd8 100644
--- a/sound/pci/ice1712/ice1724.c
+++ b/sound/pci/ice1712/ice1724.c
@@ -643,7 +643,7 @@ static int snd_vt1724_set_pro_rate(struct snd_ice1712 *ice, unsigned int rate,
 	    (inb(ICEMT1724(ice, DMA_PAUSE)) & DMA_PAUSES)) {
 		/* running? we cannot change the rate now... */
 		spin_unlock_irqrestore(&ice->reg_lock, flags);
-		return -EBUSY;
+		return ((rate == ice->cur_rate) && !force) ? 0 : -EBUSY;
 	}
 	if (!force && is_pro_rate_locked(ice)) {
 		spin_unlock_irqrestore(&ice->reg_lock, flags);
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux