Thank you for your patience. I'll update today. 李波 Logan Li MCE-RD-Software-Audio/Video VIA Technologies, Inc. (Beijing) -----邮件原件----- 发件人: Takashi Iwai [mailto:tiwai@xxxxxxx] 发送时间: 2009年10月8日 16:09 收件人: Li Bo 抄送: alsa-devel@xxxxxxxxxxxxxxxx; Harald Welte; Lydia Wang; Logan Li 主题: Re: [PATCH 1/31] HDA patch_via.c: Remove IS_VT17xx_VENDORID macro At Thu, 8 Oct 2009 15:56:51 +0800, Li Bo wrote: > > On Thu, Oct 8, 2009 at 3:36 PM, Takashi Iwai <tiwai@xxxxxxx> wrote: > > At Thu, 8 Oct 2009 15:28:17 +0800, > > Li Bo wrote: > >> > >> On Thu, Oct 8, 2009 at 2:27 PM, Takashi Iwai <tiwai@xxxxxxx> wrote: > >> > At Thu, 8 Oct 2009 14:22:07 +0800, Li Bo wrote: > >> >> > >> >> On Thu, Oct 8, 2009 at 2:16 PM, Takashi Iwai <tiwai@xxxxxxx> wrote: > >> >> > At Thu, 8 Oct 2009 14:11:42 +0800, Li Bo wrote: > >> >> >> > >> >> >> On Thu, Oct 8, 2009 at 2:03 PM, Takashi Iwai <tiwai@xxxxxxx> wrote: > >> >> >> > At Thu, 8 Oct 2009 13:27:49 +0800, Li Bo wrote: > >> >> >> >> > >> >> >> >> [ALSA] HDA VIA: Remove unused IS_VT17xx_VENDORID macro > >> >> >> >> > >> >> >> >> IS_VT17*_VENDORID macros are used nowhere, so clean them up. > >> >> >> >> > >> >> >> >> Signed-off-by: Lydia Wang <lydiawang@xxxxxxxxxxxxxx> > >> >> >> > > >> >> >> > Li, could you add your sign-off, too, when you handle the patches? > >> >> >> > Otherwise I can't merge them. > >> >> >> > > >> >> >> > > >> >> >> > thanks, > >> >> >> > > >> >> >> > Takashi > >> >> >> > > >> >> >> > >> >> >> Is that OK signed-off with LoganLi@xxxxxxxxxxxxxx with this > >> >> >> gmail liboat@xxxxxxxxx? LoganLi@xxxxxxxxxxxxxx is my company's email. > >> >> >> If not, I'll will resend them tomorrow when I go back to company. > >> >> > > >> >> > I don't care which address you use (and I don't know whether > >> >> > it matters your employer). It's fully your choice. > >> >> > > >> >> > But, if the signed address is different from the mail sender, > >> >> > add a line "From: YOUR NAME <your@mail>" at the beginning of > >> >> > the patch explicitly. > >> >> > > >> >> > > >> >> > thanks, > >> >> > > >> >> > Takashi > >> >> > > >> >> I just randomly use my gmail. I will resend them tomorrow, thank > >> >> you for teaching me:) > >> > > >> > Well, I was unclear in the text above. > >> > > >> > You can send patches with the sign-off of your company account > >> > even from your gmail account. Just add "From:" line with your > >> > company account in the patch text so that I can pick up the right address. > >> > > >> > > >> > Takashi > >> > > >> like this? > >> [ALSA] HDA VIA: Remove unused IS_VT17xx_VENDORID macro > >> > >> IS_VT17*_VENDORID macros are used nowhere, so clean them up. > >> > >> Signed-off-by: Lydia Wang <lydiawang@xxxxxxxxxxxxxx> > >> Signed-off-by: Logan Li <loganli@xxxxxxxxxxxxxx> > >> From: Li Bo <liboat@xxxxxxxxx> > > > > No, add your sign-off address, i.e. "Logan Li > > <loganli@xxxxxxxxxxxxxx>" to From: line, and put it at the beginning > > of the patch. > > > > But, now another question is who is the original author of the patch. > > Is it Lydia? Then the "From:" line should be of Lydia. In that > > way, we can clarify who is the original author. > > > > If you changed something from the original patch, better to mention > > in the changelog text, too. > > > > And, at best, add "Subject:" to each subject line, so that git-am > > can pick up properly. So, the patch head would look like: > > > > From: Lydia Wang <lydiawang@xxxxxxxxxxxxxx> > > Subject: ALSA: HDA VIA: Fix blah blah > > > > blah blah > > ... > > > > Changed foo bar by Logan Li. > > blah blah > > ... > > > > Signed-off-by: Lydia Wang <lydiawang@xxxxxxxxxxxxxx> > > Signed-off-by: Logan Li <loganli@xxxxxxxxxxxxxx> > > > > > > thanks, > > > > Takashi > > > Yes, Lydia is the original author. > like this? > > From: Lydia Wang <lydiawang@xxxxxxxxxxxxxx> > Subject: ALSA: HDA VIA: Remove unused IS_VT17xx_VENDORID macro > > IS_VT17*_VENDORID macros are used nowhere, so clean them up. > > Signed-off-by: Lydia Wang <lydiawang@xxxxxxxxxxxxxx> > Signed-off-by: Li Bo <liboat@xxxxxxxxxxxx> Yep. You can use your company address for your own sign-off here, too, if you prefer, even if you send from another address. thanks, Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
