Re: [PATCH 1/2] ASoC: AD1980/AD73311: make sure to set dev member

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Oct 06, 2009 at 01:51:50AM -0400, Mike Frysinger wrote:
> The codec driver should initialize snd_soc_codec's dev member to the
> appropriate device when setting up the device, but these codecs weren't.

> Signed-off-by: Mike Frysinger <vapier@xxxxxxxxxx>

No, this is the wrong approach - codec->dev should never be being set to
the socdev device, it should be being set to the device model device for
the CODEC (as should the dev members for the DAIs).  For ad73311 this
means it needs to be converted to use proper device model instantiation,
see wm8731 for an example of doing this.  ad1980 should be handled by
generic AC97 code in the core.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux