At Mon, 5 Oct 2009 21:28:00 +0800,
Li Bo wrote:
>
> [ALSA] HDA VIA: Remove IS_VT17xx_VENDORID macro
>
> Signed-off-by: Lydia Wang <lydiawang@xxxxxxxxxxxxxx>
In general with your all patches, please give a bit more detailed
changelog texs. For example, in this patch, it's not clear why they
should be removed and what impact this change would have.
A single line text like below would help much to understand.
IS_VT17*_VENDORID macros are used nowhere, so clean them up.
thanks,
Takashi
>
> Index: sound-2.6/sound/pci/hda/patch_via.c
> ===================================================================
> --- sound-2.6.orig/sound/pci/hda/patch_via.c 2009-09-29 18:01:12.000000000 +0800
> +++ sound-2.6/sound/pci/hda/patch_via.c 2009-09-29 18:01:16.000000000 +0800
> @@ -76,14 +76,6 @@
> #define VT1702_HP_NID 0x17
> #define VT1702_DIGOUT_NID 0x11
>
> -#define IS_VT1708_VENDORID(x) ((x) >= 0x11061708 && (x) <= 0x1106170b)
> -#define IS_VT1709_10CH_VENDORID(x) ((x) >= 0x1106e710 && (x) <= 0x1106e713)
> -#define IS_VT1709_6CH_VENDORID(x) ((x) >= 0x1106e714 && (x) <= 0x1106e717)
> -#define IS_VT1708B_8CH_VENDORID(x) ((x) >= 0x1106e720 && (x) <= 0x1106e723)
> -#define IS_VT1708B_4CH_VENDORID(x) ((x) >= 0x1106e724 && (x) <= 0x1106e727)
> -#define IS_VT1708S_VENDORID(x) ((x) >= 0x11060397 && (x) <= 0x11067397)
> -#define IS_VT1702_VENDORID(x) ((x) >= 0x11060398 && (x) <= 0x11067398)
> -
> enum VIA_HDA_CODEC {
> UNKNOWN = -1,
> VT1708,
>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
