At 29 Sep 2009 08:15:22 +0200,
krzysztof.h1@xxxxxxxxx wrote:
>
> Please drop this patch. It does not compile because it includes removed sscape_ioctl.h.
> I will send updated patch.
OK, thanks.
BTW, please add MODULE_FIRMWARE() entries. This will help to user-space
to identify which firmware files may be used.
Also...
> > -static int sscape_hw_open(struct snd_hwdep * hw, struct file *file)
> > +static int sscape_upload_microcode(struct snd_card *card, int version)
> > {
> > - register struct soundscape *sscape = get_hwdep_soundscape(hw);
> > - unsigned long flags;
> > + struct soundscape *sscape = get_card_soundscape(card);
> > + const struct firmware *init_fw = NULL;
> > + char name[14] = "sndscape.co0";
> > int err;
> >
> > - spin_lock_irqsave(&sscape->fwlock, flags);
> > + name[11] = '0' + version;
It's eaiser just to use
snprintf(name, sizeof(name), "sndscape.co%d", version);
Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
