On Sat, Sep 26, 2009 at 10:42:39AM +0530, Shilimkar, Santosh wrote: [Please fix your MUA to word wrap at 80 lines - I've reflowed the message below.] > While doing that series, we realized that there is a lot of code > common between TWL5030 and TWL6030 apart from mainly interrupt handling > and hence a common file approach is taken to avoid code duplication. The > patch " [PATCHv2 3/7] ASoC: TWL6030: Add twl6030 codec driver" gives me > an impression that there is opportunity to have a single file supporting > both IC's. IC specific code can be handled using the runtime check > depending on the revision. Can you explore this ? Looking at the code there are substantial differences between the two devices - the refactoring to move the digital section into the OMAP looks to have made a substantial difference. What might make sense is something more like the refactoring that can be seen in wm_hubs where shared functionality has been factored out into a library which can be used by more than one CODEC driver. _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
