At Mon, 28 Sep 2009 12:03:45 +0200, Pascal Terjan wrote: > > Le lundi 28 septembre 2009 à 11:50 +0200, Takashi Iwai a écrit : > > At Mon, 28 Sep 2009 11:43:11 +0200, > > Pascal Terjan wrote: > > > > > > From > > > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/195605/comments/25 > > > > > > Signed-off-by: Pascal Terjan <pterjan@xxxxxxxxxxxx> > > > > Thanks for the patch. > > I think we can merge all three using SND_PCI_QUIRK_MASK(), e.g. > > SND_PCI_QUIRK_MASK(0x104d, 0xff00, 0x9000, "Sony VAIO", STAC_9872_VAIO) > > > > Or, a bit safer like > > SND_PCI_QUIRK_MASK(0x104d, 0xfff0, 0x9000, "Sony VAIO", STAC_9872_VAIO) > > SND_PCI_QUIRK_MASK(0x104d, 0xfff0, 0x9010, "Sony VAIO", STAC_9872_VAIO) > > > > Could you check whether it's OK? > > I think so, but I can't be sure of how Sony distributed the ids > > SZ61 was reported to need model=vaio to have headphones working but I > could not find the ids anyway > > Some commenter also reported FZ11S needed model=vaio without giving any > info and without id > > Given that other model seem to need it too I think that the mask would > make sense Yep. > > Also, please make sure that this change is really needed for the > > latest alsa-driver. The recent version probes the BIOS setup, and > > it should work as is unless BIOS is broken. The quirk entries like > > the above override the BIOS setup, thus should be used only when > > really needed. > > Unfortunately we only have this for a paying customer using 2.6.29 on > stable version, and who is happy with adding model=vaio. I found that > other had reported on launchpad, but I don't have the hardware myself to > test with kernel after July commits Is the sound driver also based on 2.6.29 kernel, or built externally from the later version of alsa-driver? The HD-audio driver on 2.6.29 requires model=vaio explicitly while the later version of alsa-driver should work without model option as long as BIOS is correct. So, I'm a bit worried about adding the quirks blindly. Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel