At Tue, 22 Sep 2009 03:49:11 +0200,
Tobias Hansen wrote:
>
> @@ -443,6 +476,13 @@
> int err;
> struct us122l *us122l = US122L(card);
>
> + if (us122l->chip.dev->descriptor.idProduct == USB_ID_US144) {
> + err = usb_set_interface(us122l->chip.dev, 0, 1);
> + if (err) {
> + snd_printk(KERN_ERR "usb_set_interface error \n");
> + return false;
> + }
> + }
> err = usb_set_interface(us122l->chip.dev, 1, 1);
> if (err) {
> snd_printk(KERN_ERR "usb_set_interface error \n");
Strictly speaking, the first interface should be reset in the error
path...
> @@ -530,7 +573,7 @@
> if (err < 0)
> return err;
>
> - snd_card_set_dev(card, &intf->dev);
> + snd_card_set_dev(card, &device->dev);
> if (!us122l_create_card(card)) {
> snd_card_free(card);
> return -EINVAL;
Any reason to change this again?
This actually reverts the fix in the upstream:
3f5d3465be8f6e04f43d9b6d543fe28d4be07d78
ALSA: usx2y - reparent sound device
Also, please give your sign-off. See
$LINUX/Documentation/SubmittingPatches for details.
Could you repost with it?
thanks,
Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
