At Sun, 20 Sep 2009 01:08:58 +0200,
nowymarluk@xxxxx wrote:
>
> From: edoiks <nowymarluk@xxxxx>
>
>
> Signed-off-by: edoiks <nowymarluk@xxxxx>
Thanks for the patch.
But, are you sure that your patch works?
For example...
> diff --git a/pci/hda/patch_conexant.c b/pci/hda/patch_conexant.c
> index 9d899ed..700a430 100644
> --- a/pci/hda/patch_conexant.c
> +++ b/pci/hda/patch_conexant.c
> @@ -687,6 +687,8 @@ static struct hda_input_mux cxt5045_capture_source_benq = {
> { "IntMic", 0x1 },
> { "ExtMic", 0x2 },
> { "LineIn", 0x3 },
> + { "CD Pin", 0x4 },
> + { "Mixer ", 0x0 },
> }
> };
This doesn't work unless you change the num_items field.
> @@ -816,6 +818,14 @@ static struct snd_kcontrol_new cxt5045_benq_mixers[] = {
> HDA_CODEC_VOLUME("Line In Playback Volume", 0x17, 0x3, HDA_INPUT),
> HDA_CODEC_MUTE("Line In Playback Switch", 0x17, 0x3, HDA_INPUT),
>
> + HDA_CODEC_VOLUME("Line In Capture Volume", 0x1a, 0x03, HDA_INPUT),
> + HDA_CODEC_MUTE("Line In Capture Switch", 0x1a, 0x03, HDA_INPUT),
> + HDA_CODEC_VOLUME("Line In Playback Volume", 0x17, 0x3, HDA_INPUT),
> + HDA_CODEC_MUTE("Line In Playback Switch", 0x17, 0x3, HDA_INPUT),
This conflicts; the same item already exists.
> + HDA_CODEC_VOLUME("Mixer Capture Volume", 0x1a, 0x0, HDA_INPUT),
> + HDA_CODEC_MUTE("Mixer Capture Switch", 0x1a, 0x0, HDA_INPUT),
Does this really work, too?
Also, no corresponding CD volume?
Last but not least, please give a bit more detailed description
of your change. What it really does, and why it's needed.
Also, please give your full name with your sign-off.
thanks,
Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
