At Tue, 15 Sep 2009 13:51:16 +0200, Pavel Hofman wrote: > > Takashi Iwai wrote: > > At Tue, 15 Sep 2009 00:44:58 +0200, > > pavel.hofman@xxxxxxxxxxx wrote: > >> From: Pavel Hofman <pavel.hofman@xxxxxxxxxxx> > >> > >> > >> Signed-off-by: Pavel Hofman <pavel.hofman@xxxxxxxxxxx> > > > > Could you give a bit more changelog content? > > The summary line isn't enough for non-trivial changes. > > In this case, you changed AK4114_OPS1[012] values without any > > explanation. Please give a bit more information, what these changes > > mean, what impact they have, etc. > > Sure, I was not sure how the rules apply in git. The first line in > rebase/patch edit is a summary statement and next lines are the detailed > changelog? Thanks a lot for the info. Yes, the first line is the summary, then a blank line. The rest are changelogs, and your sign-off. Don't forget to put changelogs to each commit. A longer description is much much better than no description :) thanks, Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
