At Mon, 7 Sep 2009 11:15:19 +0100, Mark Brown wrote: > > On Mon, Sep 07, 2009 at 12:04:37PM +0900, Joonyoung Shim wrote: > > This patch is for the AK4671 codec driver using this format. > > > Signed-off-by: Joonyoung Shim <jy0922.shim@xxxxxxxxxxx> > > Applied, thanks. Where we are at it: Mark, could you fix the initialization of io_types[] in C99 style? For this case, C99 style initialization is suited better since some fields are optional now. Also, I find the current unbalanced hw_read/hw_write definitions uneasy. hw_read takes the codec instance while hw_write takes i2c instance (and hw_read_t is dead). It'd be nice if you can fix these as well. thanks, Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
