At Tue, 25 Aug 2009 16:01:15 +0400,Denis Kup wrote:> > 2009/8/25 Takashi Iwai <tiwai@xxxxxxx>:> > At Mon, 24 Aug 2009 19:57:58 +0400,> > Denis Kup wrote:> >>> >> 2009/8/24 Takashi Iwai <tiwai@xxxxxxx>> >>> >> > At Mon, 24 Aug 2009 17:10:10 +0400,> >> > Denis Kup wrote:> >> > >> >> > > Sorry, I was very busy last two months. We don't finish with this theme.> >> > > What about my patch?> >> >> >> > Please check with the latest sound GIT tree (or alsa-driver snapshot)> >> > whether it still work and repost the patch. There have been lots of> >> > changes in HD-audio driver code, so an old patch might not work any> >> > more.> >> >> >> >> >> > thanks,> >> >> >> > Takashi> >>> >>> >> I tested patch with alsa-driver-1.0.20.40.g13311.579.gcf341. All works as it> >> should.> >> > Try rather with the snapshot tarball in> > ftp://ftp.kernel.org/pub/linux/kernel/people/tiwai/snapshot/alsa-driver-snapshot.tar.gz> > The version you tried isn't the latest one.> >> >> It's diff between patched version( patch_realtek_new.c ) and unpatched:> >> > Make a patch with diff -u option (and better with -p, too).> >> >> >> > thanks,> >> > Takashi> >> > I tested with new one. All is OK, but i found strange thing that was> before(with older versions). If i make boost level for front mic very> high, speakers starts> whistle ( I think you understand me). Is it normal, or not? As Simos already mentioned, it's likely a loopback from the built-inmic via the analog mixer. Check the mixer status whether "MicPlayback Volume" or "Front Mic Playback Volume" is unmuted /adjusted. They should be muted unless you really need the analogloopback. > And diff: It's a wrong direction, i.e. to remove your change. Make for adifferent direction. Also, your MUA breaks the embedded patch, converting tabs into spaces,fold lines, etc. Either fix your MUA setting or use attachments ifit's hard to fix. A bit more comments below: > dener@linux-wpg9:~/Documents/1> diff ./patch_realtek_new.c> ./patch_realtek_old.c -u -p> --- ./patch_realtek_new.c 2009-08-25 13:44:34.000000000 +0400> +++ ./patch_realtek_old.c 2009-08-25 10:53:13.000000000 +0400> @@ -220,7 +220,6 @@ enum {> ALC888_ACER_ASPIRE_4930G,> ALC888_ACER_ASPIRE_6530G,> ALC888_ACER_ASPIRE_8930G,> - ALC888_ACER_ASPIRE_7730G,> ALC883_MEDION,> ALC883_MEDION_MD2,> ALC883_LAPTOP_EAPD,> @@ -8473,32 +8472,6 @@ static struct hda_verb alc883_acer_eapd_> { }> };> > -static struct hda_verb alc888_acer_aspire_7730G_verbs[] = {> - {0x15, AC_VERB_SET_CONNECT_SEL, 0x00},> - {0x17, AC_VERB_SET_CONNECT_SEL, 0x02},> - {0x15, AC_VERB_SET_UNSOLICITED_ENABLE, ALC880_HP_EVENT |> AC_USRSP_EN},> - { } /* end */> -};> -> -static void alc888_acer_aspire_7730G_front_automute(struct hda_codec> *codec)> -{> - unsigned int present;> -> - present = snd_hda_codec_read(codec, 0x15, 0,> - AC_VERB_GET_PIN_SENSE, 0) &> 0x80000000;> - snd_hda_codec_amp_stereo(codec, 0x14, HDA_OUTPUT, 0,> - HDA_AMP_MUTE, present ? HDA_AMP_MUTE> : 0);> - snd_hda_codec_amp_stereo(codec, 0x17, HDA_OUTPUT, 0,> - HDA_AMP_MUTE, present ? HDA_AMP_MUTE> : 0);> -} Recently, we use the common automute function instead of theown one as much as possible. Set up the pins in setup callback,instead. See other acer-aspire models as examples. > -static void alc888_acer_aspire_7730G_unsol_event(struct hda_codec> *codec,> - unsigned int res)> -{> - if ((res >> 26) == ALC880_HP_EVENT)> - alc888_acer_aspire_7730G_front_automute(codec);> -} This is no longer needed with the common automute. Could you fix and repost? Don't forget to add a changelog and yoursign-off line together with the patch. The page below is a guidancefor creating a kernel patch: http://userweb.kernel.org/~akpm/stuff/tpp.txt thanks, Takashi_______________________________________________Alsa-devel mailing listAlsa-devel@xxxxxxxxxxxxxxxxxxxx://mailman.alsa-project.org/mailman/listinfo/alsa-devel
