On Mon, Aug 17, 2009 at 04:36:56PM +0800, Shine Liu wrote: > There is a mistake in current uda134x_mute function: mute_reg has been > changed in line 162 or line 164, so uda134x_write should write > "mute_reg" but not "mute_reg & ~(1<<2)" to > UDA134X_DATA010. This is OK but please split it out into a separate patch and resend since... > Besides, because there is no DAPM configuration for uda134x, when system > starts up, snd_soc_int_card calls snd_soc_dapm_new_widgets, and > snd_soc_dapm_new_widgets calls dapm_power_widgets. In function > dapm_power_widgets, codec->dapm_widgets has no list entry, so sys_power > retains it's original value zero. Then ...this isn't, partly because I can't really follow what you're trying to do here. It looks awfully like you're trying to implement DAPM support - certainly things like adding the switches for DAC and ADC power shouldn't be there, they should be automatically managed in the drivers. _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
