Mark Brown wrote: > On Mon, Jun 15, 2009 at 09:44:31PM -0300, Daniel Ribeiro wrote: >> Extend set_tdm_slot to allow the user to arbitrarily set the frame width >> and active TX/RX slots. > >> Updates magician.c and wm9081.c for the new set_tdm_slot(). wm9081.c >> still doesn't handle the slot_width override. > >> While being there, correct an incorrect use of SlotsPerFrm(7) use in >> bitmask on pxa-ssp.c (SSCR0_SlotsPerFrm(x) is (((x) - 1) << 24)) ). > >> (this series is meant for Mark's for-2.6.32 branch) > >> Signed-off-by: Daniel Ribeiro <drwyrm@xxxxxxxxx> > > So. These have been sitting for quite some time now. Unfortunately I > went on holiday immediately after it was last submitted my Zylonite > system has been bricked for pretty much all of the time since then so > I've been remiss in following up. Sorry about that, my bad. > > My inclination here is to apply these changes - they look like a clear > win for pretty much every machine except Daniel Mack's out of tree > system which needs the 64 bit TDM slots. It's a shame to break that but > there seems to be such a clear advantage from the changes, especially > the new set_tdm_slot() API, that it seems like a win overall. I've got > a feeling that the fix for that system may have to be allowing the > machine driver to rewrite the hw_params for the CPU driver to lie about > the data format. > > I'll try to do that this week. > I seem to remember this failed on Littleton - playback just doesn't work any more, and DMA looks to be inactive. Didn't follow this thread for a long time, but Daniel, could you repost the whole series if you have any update _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
