Re: [PATCH] hda: add IbexPeak/Clarkdale HDMI model with static cvt/pin number

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 1 Aug 2009, Wu Fengguang wrote:

> -#define CVT_NID		0x02	/* audio converter */
> -#define PIN_NID		0x03	/* HDMI output pin */
> +static hda_nid_t cvt_nid;	/* audio converter */
> +static hda_nid_t pin_nid;	/* HDMI output pin */

I don't like to use static variables here. I would recommend to use a 
runtime structure to store these values.

 						Jaroslav

-----
Jaroslav Kysela <perex@xxxxxxxx>
Linux Kernel Sound Maintainer
ALSA Project, Red Hat, Inc.

_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux