On Fri, 31 Jul 2009, Takashi Iwai wrote:
> At Thu, 30 Jul 2009 16:29:54 +0200 (CEST),
> Julia Lawall wrote:
> >
> > On Thu, 30 Jul 2009, Johannes Berg wrote:
> >
> > > On Thu, 2009-07-30 at 16:11 +0200, Julia Lawall wrote:
> > > > From: Julia Lawall <julia@xxxxxxx>
> > > >
> > > > Check that the result of kzalloc is not NULL before a dereference.
> > >
> > > > irq_client = kzalloc(sizeof(struct pmf_irq_client),
> > > > GFP_KERNEL);
> > > > + if (!irq_client) {
> > > > + err = -ENOMEM;
> > > > + printk(KERN_ERR "snd-aoa: gpio layer failed to"
> > > > + " register %s irq (%d)\n", name, err);
> > > > + goto out_unlock;
> > > > + }
> > >
> > > Looks good, thanks, but I'd really drop the printk if only to not have
> > > the string there, that doesn't really seem interesting.
> >
> > The printk is based on similar error handling code a few lines later:
>
> But another problem is that the same error message is reused although
> the error condition is totally different. The kzalloc NULL isn't
> about the registration error. So, it's rather confusing.
>
> However, for this particular error path, I agree with Johannes; we can
> skip the error message since the error code ENOMEM is obvious.
OK, I will send a new patch.
julia
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
