Re: [PATCH 1/3] new ad1938 codec driver based on asoc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jul 16, 2009 at 04:00:05PM +0800, Barry Song wrote:
> Signed-off-by: Barry Song <21cnbao@xxxxxxxxx>

This is fine from a code point of view but there are a *lot* of
tab/space problems in the code.  I'd suggest running checkpatch over
your patches before sending them to make sure you catch issues like
that.  Also, the patch was against the ASoC dev branch rather than ALSA
git - the most current mailine ALSA code is in the topic/asoc branch of:

  git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound-2.6.git

Please submit patches againt that or my current queue which will be in:

  git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound-2.6.git

Since the code is all good I've applied the patch as-is but a followup
fixing the tab/space stuff would be appreciated.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux