On Wed, Jul 15, 2009 at 10:22:40AM +0900, Joonyoung Shim wrote: > On 7/14/2009 6:54 PM, Mark Brown wrote: > >> + SOC_SINGLE_EXT_TLV("MAX9877 Amp HP Left Playback Volume", > >> + MAX9877_HPL_VOLUME, 0, 31, 0, > >> + max9877_get_reg, max9877_set_reg, max9877_output_tlv), > >> + SOC_SINGLE_EXT_TLV("MAX9877 Amp HP Right Playback Volume", > >> + MAX9877_HPR_VOLUME, 0, 31, 0, > >> + max9877_get_reg, max9877_set_reg, max9877_output_tlv), > > Ideally these would be a SOC_DOUBLE_EXT_TLV() but we don't have that yet > > - would you mind sending a patch for that? > I think these would be a SOC_DOUBLE_R_EXT_TLV() because HP Left register > and HP Right register are different. If this is right, i will send a > patch for this. Yes, that sounds right (though if you want to add both macros I won't stop you!). _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel