>-----Original Message----- >From: Mark Brown [mailto:broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx] >Sent: Saturday, July 04, 2009 4:28 PM >To: Koul, Vinod >Cc: alsa-devel@xxxxxxxxxxxxxxxx; Harsha, Priya >Subject: Re: [PATCH] [RFC 8/13] Intel SST sound card driver > >On Fri, Jul 03, 2009 at 12:36:15PM +0530, Vinod Koul wrote: > >> + case SND_FS: >> + if (intsts & 0x1) { >> + /*send long push*/ >> + ret_val = snd_intelmad_generate_netlink(1, >> + AUDIO_EVENT_LONG_PRESS); >> + } >> + if (intsts & 0x2) { >> + /*send short push*/ >> + ret_val = snd_intelmad_generate_netlink(1, >> + AUDIO_EVENT_SHORT_PRESS); >> + } >> + if (intsts & 0x4) { >> + /*send headphone detect*/ >> + ret_val = snd_intelmad_generate_netlink(1, >> + AUDIO_EVENT_HP_DETECT); >> + } >> + if (intsts & 0x8) { >> + /*send headset detect*/ >> + ret_val = snd_intelmad_generate_netlink(1, >> + AUDIO_EVENT_HS_DETECT); >> + } >> + break; > >ALSA core has an interface for representing jacks to user space which >should be used here - see include/sound/jack.h. Thanks for the note. I shall look into it further. Can you suggest any example ALSA driver that uses this functionality so that I can have a reference. Also quick question around this, can I use this jack.h to event the user space? > >> + case SND_MX: > >> + case SND_NC: > >Looks like you've got one of these per vendor - does this need to be >placed into the vendor abstraction? Yes, I can place them in vendor abstractions. It would make more sense that way. I shall change it when I resubmit the patches. Thanks, Harsha _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel