Re: [PATCH] alsa/soc: add locking to mpc5200-psc-ac97 driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jun 30, 2009 at 12:50 PM, Grant Likely<grant.likely@xxxxxxxxxxxx> wrote:
> On Tue, Jun 30, 2009 at 12:18 AM, Wolfram Sang<w.sang@xxxxxxxxxxxxxx> wrote:
>>> +
>>> +     /* Force clear the data valid bit */
>>> +     in_be32(&psc_dma->psc_regs->ac97_data);
>>> +
>>
>> No mutex involved here. I think this is either a separate patch or it needs at
>> least to be mentioned in the patch description.
>
> Oops, that was sloppy.  Yes, I'll put this into a separate patch.  Thanks.

Now that you have added the mutexes, do you ever need to force clear
the valid bit?
Maybe log an error if this happens so that we can track down why.

-- 
Jon Smirl
jonsmirl@xxxxxxxxx
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel


[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux