On Tue, Jun 30, 2009 at 11:21:39AM +0200, Takashi Iwai wrote:
> Paul Fertser wrote:
> > TBH, i've not tried but i'm pretty sure it will fix the problem. I
> > tried with dlopen workaround (to increase the refcounter) in install
> > function and i tried with LD_PRELOAD'ing the library before starting
> > an alsa app; both workarounds worked.
>
> OK, I fixed this on GIT now.
Wow! Thanks a lot for this fast and proper fix! I compile-tested it,
will try running later, but it should be ok. :)
While reading the diff i saw you introduced several unused variables,
patch attached.
--
Be free, use free (http://www.gnu.org/philosophy/free-sw.html) software!
mailto:fercerpav@xxxxxxxxx
>From 3847baf57561871f09c7be48b10f3058feb117ee Mon Sep 17 00:00:00 2001
From: Paul Fertser <fercerpav@xxxxxxxxx>
Date: Tue, 30 Jun 2009 15:18:36 +0400
Subject: [PATCH] pcm_hooks: cosmetic removal of unused variables
Signed-off-by: Paul Fertser <fercerpav@xxxxxxxxx>
---
src/pcm/pcm_hooks.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/src/pcm/pcm_hooks.c b/src/pcm/pcm_hooks.c
index 2fbee73..3a99d55 100644
--- a/src/pcm/pcm_hooks.c
+++ b/src/pcm/pcm_hooks.c
@@ -99,7 +99,6 @@ static int snd_pcm_hooks_close(snd_pcm_t *pcm)
}
}
while (!list_empty(&h->dllist)) {
- struct snd_pcm_hook_dllist *dl;
pos = h->dllist.next;
hook_remove_dlobj(list_entry(pos, struct snd_pcm_hook_dllist, list));
}
@@ -345,7 +344,6 @@ static int snd_pcm_hook_add_conf(snd_pcm_t *pcm, snd_config_t *root, snd_config_
snd_config_iterator_t i, next;
int (*install_func)(snd_pcm_t *pcm, snd_config_t *args) = NULL;
void *h = NULL;
- struct snd_pcm_hook_dllist *dl;
if (snd_config_get_type(conf) != SND_CONFIG_TYPE_COMPOUND) {
SNDERR("Invalid hook definition");
--
1.6.1.3
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
