Re: [PATCH] ASoC: TWL4030: Correct bypass event for voice sidetone

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tuesday 23 June 2009 03:34:07 ext Lopez Cruz, Misael wrote:
> Event for voice sidetone was being interpreted as an
> analog HiFi bypass event because VSTPGA register offset
> is less than ARXR2_APGA_CTL offset. Reordering the
> register checks allows to handle voice digital bypass
> event properly.
>
> Signed-off-by: Misael Lopez Cruz <x0052729@xxxxxx>
> ---
>  sound/soc/codecs/twl4030.c |   20 +++++++++++++-------
>  1 files changed, 13 insertions(+), 7 deletions(-)

Good catch.

BTW: I think I'll try to get rid of this bypass handling at some point.
Now that ASoC core has support for keeping the codec in BIAS_ON when any of 
the paths are active we should not need this black magic with the bypasses.

But I'm afraid this has to wait, since I will start my summer holiday quite 
soon...

Acked-by: Peter Ujfalusi <peter.ujfalusi@xxxxxxxxx>

_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux