On Fri, Jun 19, 2009 at 07:13, Mark Brown wrote:> On 19 Jun 2009, at 12:05, Mike Frysinger wrote:>> On Fri, Jun 19, 2009 at 06:47, Mark Brown wrote:>>> On Fri, Jun 19, 2009 at 05:28:15PM +0800, Barry Song wrote:>>>> 1. add AD1938 codec driver (codec)>>>> 2. add blackfin SPORT-TDM DAI and PCM driver (platform)>>>> 3. add bf5xx board with AD1938 driver (machine)>>>>>> As Liam said you really need to submit this as a patch series rather>>> than as a single big patch - as your commit log here indicates you've>>> got several different things going on here.>>>> blah, i had this queued locally with a "todo:split". wanted to wait>> for Barry to finish developing the driver first though.>>>> at any rate, i hate to sound like a broken record wrt my alsa>> ignorance, but i'm thinking the logical split would be like Barry>> numbered it -- one patch for sound/codec/, one patch for the TDM>> transport, and one patch for hooking up the AD1938 to TDM.>> Yes, though if the new DAI format had been required it would be worth> considering a separate patch for it.
OK, Barry can handle this, otherwise i'll split it up in my git andsend him the repo info
>>>> +static int __devinit ad1938_spi_probe(struct spi_device *spi)>>>> +{>>>> + spi->dev.power.power_state = PMSG_ON;>>>> + ad1938_socdev->card->codec->control_data = spi;>>>> +>>>> + return 0;>>>> +}>>>> +>>>> +static int __devexit ad1938_spi_remove(struct spi_device *spi)>>>> +{>>>> + return 0;>>>> +}>>>>>> Your device probing should all be restructured so that the SPI device>>> for the CODEC is registered as any other SPI device rather than being>>> set up as part of probing the ASoC device. See the wm8731 driver for>>> an example of doing this for a SPI device.>>>>>> This will require that the arch code for any systems with the ad1938>>> do the setup of the device.>>>> so should sound/soc/blackfin/bf5xx-ad1938.c even exist in the first place>> ?>> Yes. It is needed in order to specify how things are hooked up on a given> board.
to look at the wm8731 then, these are good examples of how it's done ?sound/soc/atmel/sam9g20_wm8731.csound/soc/pxa/corgi.c-mike_______________________________________________Alsa-devel mailing listAlsa-devel@xxxxxxxxxxxxxxxxxxxx://mailman.alsa-project.org/mailman/listinfo/alsa-devel
