On Sat, Jun 13, 2009 at 7:44 PM, Mark
Brown<broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
> On Sat, Jun 13, 2009 at 05:00:00PM +0200, Manuel Lauss wrote:
>
>> -static int au1xpsc_ac97_suspend(struct snd_soc_dai *dai)
>> +static int au1xpsc_ac97_suspend(struct platform_device *pdev, pm_message_t m)
>> {
>> /* save interesting registers and disable PSC */
>> au1xpsc_ac97_workdata->pm[0] =
>> @@ -328,7 +366,7 @@ static int au1xpsc_ac97_suspend(struct snd_soc_dai *dai)
>> return 0;
>> }
>
> I'm don't think this is a good idea - it will remove any sequencing
> between the suspend of the various ASoC device components, meaning that
> the AC97 controller could suspend before the rest of ASoC. This would
Reverted back,
> One other thing I'd say is that before registering the DAIs you should
> assign the dev field in the DAI structure to be the struct device that
> was used to probe the DAI.
Done.
This patch unfortunately breaks PM (no sound after suspend-to-ram), so
may take a while until I resend.
Thank you!
Manuel Lauss
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
