On Wed, Jun 03, 2009 at 17:42:37, Mark Brown wrote: > On Wed, Jun 03, 2009 at 04:33:51PM +0530, chaithrika wrote: > > > > Why is the McASP driver using platform data called > > > 'evm_snd_patform_data'? > > > This suggests that there's some abstraction problem with the separation > > > between the machine and McASP drivers. > > > The platform data consists of information specific to EVM and SoC > > and is used by the platform driver (McASP driver) to get relevant > > data. Therefore it seems right to use the platform data here. > > Please let me know your opinion. > > It's not the *use* of platform data, it's the fact that you are calling > this *EVM* platform data. This suggests an abstraction issue somewhere > along the line - presumably not all machines with these processors are > EVMs. Some of the other issues myself and David identified suggest that > there are some issues there. > > If this is system-specific configuration data purely for the McBSP port > it shouldn't mention the EVMs in the name. > OK. I will rename the structure to 'snd_platform_data'. Thanks, Chaithrika _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
