On Mon, Apr 27, 2009 at 4:09 PM, Mark Brown <broonie@xxxxxxxxxxxxx> wrote: > On Mon, Apr 27, 2009 at 04:05:10PM -0400, Jon Smirl wrote: >> On Mon, Apr 27, 2009 at 3:35 PM, Mark Brown >> <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote: > >> > Why are you exporting these? ?They should all be accessed via... > >> This is part of what is broken in the driver. I have later patches >> that fix it but those patches are more complex. > > Could you go into more detail on this, please? Why aren't you just > moving them directly to the vtable of the DMA driver? The vtable for DMA driver doesn't have startup/shutdown entry points. It takes a more complicated change to fix this, The intention was to mechanically split the driver into two files in order to remove the noise of the reorg from the subsequent patch series. These patches don't fix anything, they just break the driver in two. I need the exports in order to keep it building so that it will be bisectable. These entry points get fixed in later patches. -- Jon Smirl jonsmirl@xxxxxxxxx _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
