At Thu, 16 Apr 2009 22:39:35 -0700 (PDT), James Gardiner wrote: > > > > > > --- On Tue, 4/14/09, Takashi Iwai <tiwai@xxxxxxx> wrote: > > > > > Thanks for the patch. The change looks almost good to me. > > See some comments below > > > > > > > > > + spec->num_dmics = 1; > > > + spec->num_dmuxes = 2; > > > + stac92xx_auto_set_pinctl(codec, 0x1c, 2); > > > > The number "2" doesn't look cute... > > > > Could you fix and repost the patch? > > > > > > thanks, > > > > Takashi > > Are you worried it looks like a magic number? Or am I supposed to be > looking for something else? Or would a '#define' be more what > you're talking about? Use constants defined in hda_codec.h. For pin-setup, AC_PINCTL_* can be used. > Can you (simple) explain to me what the PCI_QUIRK stuff does? The driver identifies the specific model via PCI SSID (not codec SSID). Check "lspci -nv" output and pass the value there. thanks, Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
