Re: [PATCH] General fix for Palm27x aSoC driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Apr 12, 2009 at 06:58:42PM +0200, Marek Vasut wrote:

> +static struct platform_device palmld_pxa2xx_pcm = {
> +	.name = "pxa2xx-pcm",
> +	.id   = -1,
> +};

This should follow the pattern that everything else uses with the struct
platform_device in devices.c and board files triggering registration of
that.

> +static struct platform_device palmld_pxa2xx_ac97 = {
> +	.name = "pxa2xx-ac97",
> +	.id   = -1,
> +	.dev  = {
> +		.platform_data = &palmld_ac97_pdata,
> +	},
> +};

No, use pxa_set_ac97_info().

> +static struct platform_device palmld_wm9712_codec = {

No, the WM9712 is not a platform device.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux