Re: [PATCH v2 1/2] alsa: ASoC driver for s6000 I2S interface

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Mar 28, 2009 at 07:47:01PM +0100, Daniel Glöckner wrote:
> This patch adds a driver for the I2S interface found on Stretch s6000
> family processors.

This all looks good - the only concern I have is the issue with the
polarity of the clock signals I mentioned in reply to the machine
driver.  The code in the machine driver does make it look like the I2S
driver is using the opposite polarity to that expected.  If that's not
the case then I guess the thing to do is have some documentation in the
machine driver explaining what's going on.

In order to simplify review I've applied both patches to the s6000
branch of my sound git repository.  Please submit any changes as
incremental patches against that rather than as whole new patches.

Thanks!
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel


[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux