On Thu, Apr 02, 2009 at 09:50:07PM -0400, Naresh Medisetty wrote:
> McASP on DM646x can operate in DIT (S/PDIF) where no codec is needed.
> This patch provides stub codec that can be used in these configurations.
> On DM646x EVM the McASP1 is connected to the S/PDIF out.
This looks pretty good apart from the small issues below but it occurs
to me that this would probably work for any S/PDIF transciever - perhaps
the driver should be renamed to something more generic like
spdif_transciever?
> +static struct platform_driver davinci_dit_driver = {
> + .probe = davinci_dit_probe,
> + .remove = davici_dit_remove,
Spelling mistake?
> +#ifdef CONFIG_SND_SOC_CODEC_STUBS
> +extern struct snd_soc_dai dit_stub_dai[];
> +extern struct snd_soc_dai dir_stub_dai[];
> +#else
> +#define dit_stub_dai NULL
> +#define dir_stub_dai NULL
> +#endif
No need to do the ifdefs here.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
