Re: [PATCH 3/9] ARM: DaVinci: ASoC: Adds header file for McASP Audio Layer for TI DM646X processor

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 16, 2009 at 08:03:22AM -0400, Naresh Medisetty wrote:

> +/*
> + * DAVINCI_MCASP_PWREMUMGT_REG - Power Down and Emulation Management
> + *     Register Bits
> + */
> +#define FREE         BIT(0)
> +#define SOFT         BIT(1)

These (and most of your other register bit names) really need to be
namespaced.  I'd also suggest considering moving the register
definitions out of here and into the C file - it looks like nothing else
ever ought to be peering at them?
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux