Re: [PATCH 1/2] Echoaudio: Add support for Indigo express cards

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



At Sun, 15 Mar 2009 21:36:42 +0100,
Giuliano Pochini wrote:
> 
> This patch adds support for IndigoIOx and IndigoDJx. I tested IndigoIOx
> myself, and Carmen Rocco tested the IndigoDJx. It wasn't tested
> extensively, but I think it stable enough. Maybe you want to mark it as
> experimental anyway. The soundcard matrix should be updated as well, but
> the page is locked. These two cards have the same features of their
> respective CARDBUS versions. The links to the manufacturer's site are:
> http://www.echoaudio.com/Products/ExpressCard/IndigoDJx/ and
> http://www.echoaudio.com/Products/ExpressCard/IndigoIOx/ .
> 
> I want to thank Echoaudio again for their support.
> 
> 
> This patch adds support for IndigoIOx and IndigoDJx.
> 
> Signed-off-by Giuliano Pochini <pochini@xxxxxxxx>

The code looks almost good, but could you do the following?

- split to two patches, one for kernel tree and one for alsa-driver
  tree
- run checkpatch.pl against the patch and fix issues reported there


thanks,

Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux