On Thursday 12 March 2009 07:43:27 Takashi Iwai wrote:
> At Wed, 11 Mar 2009 22:22:39 +0100,
>
> Gregorio Guidi wrote:
> > On Tuesday 10 March 2009 15:49:38 Takashi Iwai wrote:
> > > At Mon, 9 Mar 2009 20:19:35 +0100,
> > >
> > > ...
> > >
> > > Thanks, that helps for debugging.
> > >
> > > Looking through the current patch_conexant.c, there are other messy
> > > codes there, too. So I cleaned up and fixed it on sound git tree
> > > now. Any chance to try it out? The GIT tree is found at:
> > >
> > > git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound-2.6.git
> >
> > I managed to test a kernel snapshot with the latest changes, thanks for
> > taking the time to refactor and clean up the code there.
>
> Thanks for testing.
>
> > There are still issues, though: at the moment, the "Speaker" control does
> > not work. Consequently, automute does not work and Master only controls
> > headphones.
>
> Hm, doesn't "Speaker" give any change if you unplug the headphone?
> It should change the output volume of widget 0x1d. If it's true, there
> can be a few reasons:
>
> A. The real speaker output pin isn't 0x1d but another pin
>
> B. The widget 0x1d has a problem with connection to 0x19
>
> C. The widget 0x1d has no output amp control despite the description
To clarify: the speakers make sounds, but volume control and muting do not
work.
Actually, now that I start to understand how these widget connections work, I
see the problem is simpler: after changing the 0x1d connection (routing the
speakers to 0x19) with {0x1d, AC_VERB_SET_CONNECT_SEL, 0x1}, you have to
update the other places where the 0x1d widget is used (see patch). This also
explains the problem originally reported where Headphone didn't work (here and
in bug #3091).
With just the following patch applied on top of the git tree everything works
nicely (Headphone, Speaker, Master, automute all work as expected).
diff -Nur sound-2.6.git.orig/sound/pci/hda/patch_conexant.c
sound-2.6.git/sound/pci/hda/patch_conexant.c
--- sound-2.6.git.orig/sound/pci/hda/patch_conexant.c 2009-03-12
14:56:20.000000000 +0100
+++ sound-2.6.git/sound/pci/hda/patch_conexant.c 2009-03-12
14:29:48.000000000 +0100
@@ -1196,7 +1196,7 @@
* the headphone jack
*/
bits = (!spec->hp_present && spec->cur_eapd) ? 0 : HDA_AMP_MUTE;
- snd_hda_codec_amp_stereo(codec, 0x1d, HDA_OUTPUT, 0,
+ snd_hda_codec_amp_stereo(codec, 0x1d, HDA_OUTPUT, 0x01,
HDA_AMP_MUTE, bits);
bits = spec->cur_eapd ? 0 : HDA_AMP_MUTE;
snd_hda_codec_amp_stereo(codec, 0x13, HDA_OUTPUT, 0,
@@ -1214,7 +1214,7 @@
AC_VERB_GET_PIN_SENSE, 0) & 0x80000000;
bits = (spec->hp_present || !spec->cur_eapd) ? HDA_AMP_MUTE : 0;
- snd_hda_codec_amp_stereo(codec, 0x1d, HDA_OUTPUT, 0,
+ snd_hda_codec_amp_stereo(codec, 0x1d, HDA_OUTPUT, 0x01,
HDA_AMP_MUTE, bits);
}
@@ -1276,7 +1276,7 @@
};
static struct snd_kcontrol_new cxt5047_hp_spk_mixers[] = {
- HDA_CODEC_VOLUME("Speaker Playback Volume", 0x1d, 0x00, HDA_OUTPUT),
+ HDA_CODEC_VOLUME("Speaker Playback Volume", 0x1d, 0x01, HDA_OUTPUT),
HDA_CODEC_VOLUME("Headphone Playback Volume", 0x13, 0x00, HDA_OUTPUT),
{}
};
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
