This patch should be named :set constraint only if the value is not 0. I found that sometimes substream may be not NULL,but runtime can be NULL,So the previous way will cause Kernel to crash. Cliff >-----Original Message----- >From: Mark Brown [mailto:broonie@xxxxxxxxxxxxx] >Sent: Friday, March 06, 2009 8:35 PM >To: Bryan Wu >Cc: Cliff Cai; alsa-devel@xxxxxxxxxxxxxxxx; >linux-kernel@xxxxxxxxxxxxxxx >Subject: Re: [PATCH 2/5] ASoC: ssm2602 codec: fix >bug - kernelwill crash when record and play in bf527-ezkit > >On Fri, Mar 06, 2009 at 03:53:27PM +0800, Bryan Wu wrote: > >> set constraint only if the value is not 0, change the >configuring way >> for sport > >This changelog doesn't appear to apply to this patch - it >looks like was copied from the previous one? This patch >appears to suffer from a similar issue where only the first >format set by an application can ever be used, though since >this changes the constraints that are set by the driver >there's no possibility that applications will end up trying to >use a sample format that the hardware is not configured for. > >Do we really need such a heavy handed fix here - what is the >issue that's being fixed? > _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
