On Wed, Mar 04, 2009 at 08:42:22PM +0000, Mark Brown wrote: > On Wed, Mar 04, 2009 at 09:39:11PM +0100, Daniel Mack wrote: > > On Wed, Mar 04, 2009 at 08:33:52PM +0000, Mark Brown wrote: > > > > I'd expect an error to be reported here - if we needed to change the > > > settings and can't things could go wrong. Ideally it'd check to see if > > > the DAI format was being changed and only error if it was. > > > In my tests, pxa_ssp_set_dai_fmt() was simply called twice, once for the > > input, once for the ouput. Hence I believed a silent exit in such a case > > That'll be because you weren't changing the DAI format - hence my > comment about only erroring if the format is changed. Ok, that makes sense. We should probably do something silimar in set_hw_params() were we also currently exit silently in case of running streams. I'll post a new set soon when we sorted out more things on the other patches. Daniel _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
