On Sun, Mar 1, 2009 at 9:25 PM, Eric Miao <eric.y.miao@xxxxxxxxx> wrote: For starters, your patch is missing a list of files changed, so it's hard for me to review it. > diff --git a/sound/soc/codecs/cs4270.c b/sound/soc/codecs/cs4270.c > index f1aa0c3..c6e155c 100644 > --- a/sound/soc/codecs/cs4270.c > +++ b/sound/soc/codecs/cs4270.c > @@ -635,6 +635,17 @@ error: > > #endif /* USE_I2C*/ > > +#ifdef USE_I2C This patch won't apply, because it's based on an older version of cs4270.c. -- Timur Tabi Linux kernel developer at Freescale _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel