At Sat, 21 Feb 2009 16:59:47 +0000, Peter Stokes wrote: > > Hi, > > The following patches provide minor updates to the Arcam AV control plug-in. > > * [PATCH 1/2] Remove incorrect usage of the static SHM ID variable > * [PATCH 2/2] Refactor control specifications to facilitate addition of "numid" optimisation > > Takashi, > > I attempted to follow the pattern of your recent commits regarding the "numid" optimisations for external control plug-ins. > Hopefully I've provided the correct behavior. Thanks, applied now. > Something that am not sure about is whether I should be calling > the "snd_ctl_elem_id_set_numid()" function from "ctl_arcam_av.c" "arcam_av_read_event()" either in addition or instead of > the calls to the "snd_ctl_elem_id_set_name()" function? Better to put both. The find_elem() should fill the id fields as much as possible in return. Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
