On Fri, Feb 06, 2009 at 05:25:13PM +0100, Takashi Iwai wrote:
> At Wed, 04 Feb 2009 15:44:12 +0100,
> I wrote:
> >
> > At Wed, 4 Feb 2009 23:20:12 +0900,
> > Kusanagi Kouichi wrote:
> > >
> > > On Wed, Feb 04, 2009 at 12:17:14PM +0100, Takashi Iwai wrote:
> > > > Fair enough.
> > > >
> > > > Though, there is still one problem -- not all models enabled the
> > > > analog beep path. So, the next step is to create beep controls in all
> > > > possible situations.
> > >
> > > I'll try later.
> >
> > This can be a separate (additional) patch. Let's get the first patch
> > into the main tree so that one can work on further issues.
>
> ... and now fixed on sound git tree.
Some models for alc268 still seems to lack a beep control.
Is it OK to add a beep control unconditionally?
>From 184d1a1b1c3976a8a76b2f3b40ad02992b44db48 Mon Sep 17 00:00:00 2001
From: Kusanagi Kouichi <slash@xxxxxxxxxxxxxx>
Date: Sat, 7 Feb 2009 19:30:05 +0900
Subject: [PATCH] hda: Add mising beep controls for realtek alc268 codec.
So far, some models didn't add a beep control since they don't use
analog beep in.
Signed-off-by: Kusanagi Kouichi <slash@xxxxxxxxxxxxxx>
---
sound/pci/hda/patch_realtek.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index f594a09..2fa26f9 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -11887,7 +11887,7 @@ static struct snd_pci_quirk alc268_cfg_tbl[] = {
static struct alc_config_preset alc268_presets[] = {
[ALC267_QUANTA_IL1] = {
- .mixers = { alc267_quanta_il1_mixer },
+ .mixers = { alc267_quanta_il1_mixer, alc268_beep_mixer },
.init_verbs = { alc268_base_init_verbs, alc268_eapd_verbs,
alc267_quanta_il1_verbs },
.num_dacs = ARRAY_SIZE(alc268_dac_nids),
@@ -11969,7 +11969,7 @@ static struct alc_config_preset alc268_presets[] = {
},
[ALC268_ACER_ASPIRE_ONE] = {
.mixers = { alc268_acer_aspire_one_mixer,
- alc268_capture_alt_mixer },
+ alc268_capture_alt_mixer, alc268_beep_mixer },
.init_verbs = { alc268_base_init_verbs, alc268_eapd_verbs,
alc268_acer_aspire_one_verbs },
.num_dacs = ARRAY_SIZE(alc268_dac_nids),
--
1.5.6.5
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
